Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MkDocs implementation #870

Merged
merged 18 commits into from Mar 9, 2021
Merged

add MkDocs implementation #870

merged 18 commits into from Mar 9, 2021

Conversation

ronaudinho
Copy link
Contributor

resolves #868

This is mostly based on existing implementation in Starboard, keeping the structure of current README where possible (some additions and modifications where necessary).

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #870 (96620b4) into main (a00d719) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   68.50%   68.48%   -0.02%     
==========================================
  Files          57       56       -1     
  Lines        2210     2158      -52     
==========================================
- Hits         1514     1478      -36     
+ Misses        564      556       -8     
+ Partials      132      124       -8     
Impacted Files Coverage Δ
internal/app.go 98.38% <ø> (-0.10%) ⬇️
internal/artifact/config/config.go 81.81% <ø> (-1.52%) ⬇️
internal/client/config/config.go 79.31% <ø> (-1.34%) ⬇️
internal/config/image.go 0.00% <ø> (-100.00%) ⬇️
pkg/detector/library/detect.go 0.00% <0.00%> (ø)
pkg/detector/library/npm/compare.go 100.00% <ø> (ø)
pkg/detector/ospkg/alpine/alpine.go 94.73% <ø> (ø)
pkg/detector/ospkg/debian/debian.go 81.63% <ø> (ø)
pkg/github/github.go 58.00% <0.00%> (ø)
pkg/utils/utils.go 48.21% <ø> (+8.50%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0497286...96620b4. Read the comment docs.

# Note: It is not the same as ${{ secrets.GITHUB_TOKEN }} !
GH_TOKEN: ${{ secrets.MKDOCS_GH_TOKEN }}
- run: |
git config user.name "ronaudinho"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we use @danielpacak 's credentials here? @knqyf263 I believe I don't have the privilege to set env vars for GitHub workflow

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I replaced it with ORG_GITHUB_TOKEN.

- pymdownx.highlight
- pymdownx.superfences
- admonition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMIIW, but this looks like it is generated during deployment.

@knqyf263 knqyf263 force-pushed the mkdocs branch 3 times, most recently from 3a377ce to 9747f8e Compare March 9, 2021 17:42
@knqyf263 knqyf263 merged commit becd508 into aquasecurity:main Mar 9, 2021
knqyf263 added a commit that referenced this pull request Mar 10, 2021
* mkdocs: add top level nav

* mkdocs: add installation nav

* mkdocs: add quick-start nav

* mkdocs: add examples nav

* mkdocs: add CI nav

* mkdocs: add vuln-detection nav

* mkdocs: add comparison nav

* mkdocs: add usage nav

* mkdocs: add migration nav

* mkdocs: add FAQ nav

* mkdocs: add mkdocs.yml

* mkdocs: add github workflow

* docs: update documents

* fix links

* chore(ci): use ORG_GITHUB_TOKEN

* chore(mkdocs): use mike

* chore(ci): support dev

* chore(ci): documentation test

Co-authored-by: knqyf263 <knqyf263@gmail.com>
knqyf263 added a commit that referenced this pull request Mar 10, 2021
* fix(log): set the default logger

* feat: support plugins

* feat(plugin): add run command

* feat(plugin): add uninstall command

* test(plugin): add tests

* chore(ci): pin go version

* chore(ci): disable G204

* refactor: fix lint issues

* feat(plugin): skip downloading installed plugins

* feat: add TRIVY_RUN_AS_PLUGIN

* support Ubuntu 20.10 (#876)

* docs(README): update ubuntu versions (#877)

* add MkDocs implementation (#870)

* mkdocs: add top level nav

* mkdocs: add installation nav

* mkdocs: add quick-start nav

* mkdocs: add examples nav

* mkdocs: add CI nav

* mkdocs: add vuln-detection nav

* mkdocs: add comparison nav

* mkdocs: add usage nav

* mkdocs: add migration nav

* mkdocs: add FAQ nav

* mkdocs: add mkdocs.yml

* mkdocs: add github workflow

* docs: update documents

* fix links

* chore(ci): use ORG_GITHUB_TOKEN

* chore(mkdocs): use mike

* chore(ci): support dev

* chore(ci): documentation test

Co-authored-by: knqyf263 <knqyf263@gmail.com>

* docs: add plugins

* chore: remove stale workflow

* refactor: fix lint issues

Co-authored-by: Huang Huang <mozillazg101@gmail.com>
Co-authored-by: aprp <doelaudi@gmail.com>
liamg pushed a commit that referenced this pull request Jun 7, 2022
* mkdocs: add top level nav

* mkdocs: add installation nav

* mkdocs: add quick-start nav

* mkdocs: add examples nav

* mkdocs: add CI nav

* mkdocs: add vuln-detection nav

* mkdocs: add comparison nav

* mkdocs: add usage nav

* mkdocs: add migration nav

* mkdocs: add FAQ nav

* mkdocs: add mkdocs.yml

* mkdocs: add github workflow

* docs: update documents

* fix links

* chore(ci): use ORG_GITHUB_TOKEN

* chore(mkdocs): use mike

* chore(ci): support dev

* chore(ci): documentation test

Co-authored-by: knqyf263 <knqyf263@gmail.com>
liamg pushed a commit that referenced this pull request Jun 7, 2022
* fix(log): set the default logger

* feat: support plugins

* feat(plugin): add run command

* feat(plugin): add uninstall command

* test(plugin): add tests

* chore(ci): pin go version

* chore(ci): disable G204

* refactor: fix lint issues

* feat(plugin): skip downloading installed plugins

* feat: add TRIVY_RUN_AS_PLUGIN

* support Ubuntu 20.10 (#876)

* docs(README): update ubuntu versions (#877)

* add MkDocs implementation (#870)

* mkdocs: add top level nav

* mkdocs: add installation nav

* mkdocs: add quick-start nav

* mkdocs: add examples nav

* mkdocs: add CI nav

* mkdocs: add vuln-detection nav

* mkdocs: add comparison nav

* mkdocs: add usage nav

* mkdocs: add migration nav

* mkdocs: add FAQ nav

* mkdocs: add mkdocs.yml

* mkdocs: add github workflow

* docs: update documents

* fix links

* chore(ci): use ORG_GITHUB_TOKEN

* chore(mkdocs): use mike

* chore(ci): support dev

* chore(ci): documentation test

Co-authored-by: knqyf263 <knqyf263@gmail.com>

* docs: add plugins

* chore: remove stale workflow

* refactor: fix lint issues

Co-authored-by: Huang Huang <mozillazg101@gmail.com>
Co-authored-by: aprp <doelaudi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: migrate README to MkDocs
2 participants