Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a help message when the context's deadline passes #955

Merged
merged 1 commit into from Apr 27, 2021

Conversation

knqyf263
Copy link
Collaborator

$ trivy image -timeout 1s sequenceiq/hadoop-docker:2.7.0
2021-04-27T20:35:06.245+0900    WARN    increase --timeout value
2021-04-27T20:35:06.245+0900    FATAL   scan error: image scan failed: failed analysis: analyze error: timeout: context deadline exceeded

@knqyf263 knqyf263 self-assigned this Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #955 (8220826) into main (a00d719) will decrease coverage by 6.30%.
The diff coverage is 52.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   68.50%   62.19%   -6.31%     
==========================================
  Files          57       65       +8     
  Lines        2210     2611     +401     
==========================================
+ Hits         1514     1624     +110     
- Misses        564      853     +289     
- Partials      132      134       +2     
Impacted Files Coverage Δ
pkg/commands/artifact/config.go 81.81% <ø> (ø)
pkg/commands/artifact/fs.go 0.00% <0.00%> (ø)
pkg/commands/artifact/image.go 0.00% <0.00%> (ø)
pkg/commands/artifact/repository.go 0.00% <0.00%> (ø)
pkg/commands/artifact/run.go 0.00% <0.00%> (ø)
pkg/commands/artifact/wire_gen.go 0.00% <0.00%> (ø)
pkg/commands/client/config.go 79.31% <ø> (ø)
pkg/commands/client/run.go 0.00% <0.00%> (ø)
pkg/commands/client/wire_gen.go 0.00% <0.00%> (ø)
pkg/commands/config/cache.go 100.00% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a4e7e...8220826. Read the comment docs.

@knqyf263 knqyf263 merged commit 1385fa4 into main Apr 27, 2021
@knqyf263 knqyf263 deleted the feat/timeout_option branch April 27, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants