feat(eol): added eol dates #148
Conversation
There was a problem hiding this comment.
In addition, we have to add this updater here.
https://github.com/aquasecurity/vuln-list-update/blob/main/.github/workflows/update.yml
main.go
Outdated
| if err := src.Update(); err != nil { | ||
| return xerrors.Errorf("Alpine end of life dates update error: %w", err) | ||
| } | ||
| commitMsg = "CBL-Mariner Vulnerability Data" |
There was a problem hiding this comment.
Thanks, changed
eol/alpine/eof_test.go
Outdated
| want map[string]time.Time | ||
| }{ | ||
| { | ||
| name: "happy path", |
eol/alpine/eof.go
Outdated
| if err := os.MkdirAll(dir, os.ModePerm); err != nil { | ||
| return xerrors.Errorf("failed to mkdir: %w", err) | ||
| } |
There was a problem hiding this comment.
WriteJSON also creates a dir.
Lines 13 to 15 in 357afc5
There was a problem hiding this comment.
oh, i didn't see that. Thank you. Removed
eol/alpine/eof.go
Outdated
| dir := filepath.Join(config.vulnListDir, eolAlpineFolder) | ||
| if err := os.RemoveAll(dir); err != nil { | ||
| return xerrors.Errorf("unable to remove github security advisory directory: %w", err) | ||
| } |
There was a problem hiding this comment.
It is a single file, right? Looks like we don't have to remove dir as it overwrites the existing file.
eol/alpine/eof.go
Outdated
| } | ||
| } | ||
|
|
||
| func (config Config) Update() error { |
There was a problem hiding this comment.
nit: a single letter name is fine.
| func (config Config) Update() error { | |
| func (c Config) Update() error { |
eol/alpine/eof.go
Outdated
| return eolDates, nil | ||
| } | ||
|
|
||
| func (config Config) save(dates map[string]time.Time) error { |
eol/alpine/eof.go
Outdated
|
|
||
| const ( | ||
| eolAlpineFolder = "eol/alpine" | ||
| eolAlpineFile = "eol-alpine" |
There was a problem hiding this comment.
What if we have an entire file name here?
| eolAlpineFile = "eol-alpine" | |
| eolAlpineFile = "alpine.json" |
Added, thanks! |
DmitriyLewen
changed the title
Description
Added list of end-of-life dates.
EOL dated taken from: