Implemented new feature for enable audio , created options sound for All or only errors #41
Conversation
SaurabPoudel
commented
Oct 8, 2023
SaurabPoudel
commented
- But there is a warning : The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page. I couldn't fix that
| enableSoundStyle: EnableSoundStyle.All, | ||
| whitespaceStyle: WhitespaceStyle.Bullet, | ||
| sounds: false, |
There was a problem hiding this comment.
Let's remove these two properties and merge them into one.
So, remove the enableSourndsStyle and replace sounds with
playSounds: PlaySounds.None,
| sounds: booleanProp("textDisplay.sounds", false), | ||
| enableSoundStyle: enumProp( | ||
| "textDisplay.enableSoundStyle", | ||
| EnableSoundStyle, | ||
| EnableSoundStyle.All, | ||
| ), |
There was a problem hiding this comment.
Make these properties match the type definitions above.
playSounds: enumProp("textDisplay.playSounds", PlaySounds, PlaySounds.None),
| @@ -38,6 +38,7 @@ export function toTextInputSettings(settings: Settings): TextInputSettings { | |||
| export type TextDisplaySettings = { | |||
| readonly caretShapeStyle: CaretShapeStyle; | |||
| readonly caretMovementStyle: CaretMovementStyle; | |||
| readonly enableSoundStyle: EnableSoundStyle; | |||
| readonly whitespaceStyle: WhitespaceStyle; | |||
| readonly sounds: boolean; | |||
| } as const; | ||
|
|
||
| export function toTextDisplaySettings(settings: Settings): TextDisplaySettings { | ||
| return { | ||
| caretShapeStyle: settings.get(textDisplayProps.caretShapeStyle), | ||
| caretMovementStyle: settings.get(textDisplayProps.caretMovementStyle), | ||
| enableSoundStyle: settings.get(textDisplayProps.enableSoundStyle), |
There was a problem hiding this comment.
Please keep the order of properties match the order in the type definition.
| @@ -49,7 +50,7 @@ export const Controller = memo(function Controller({ | |||
| function usePracticeState(state: PracticeState) { | |||
| const keyboard = useKeyboard(); | |||
| const [lines, setLines] = useState(state.lines); // Forces ui update. | |||
|
|
|||
| const { settings } = useSettings(); | |||
There was a problem hiding this comment.
A big problem here. You use the settings variableinside a hook, but this variable is not marked as a hook dependency. You should catch this error if you run linternpm run lint`.
| playSound(TextInputSound.Blip); | ||
| break; | ||
| function playFeedbackSound(feedback: Feedback, option: number): void { | ||
| if (option === 1) { |
There was a problem hiding this comment.
Please don't use magic numbers. Use PlaySounds.None, PlaySounds.All, etc.
|
Hey, I've made my own change-list to implement this feature -- https://github.com/aradzie/keybr.com/tree/sounds |
|
Hey Saurab. I know you wanted to contribute, but this is a simple change and it takes equal time to review your PR and to implement this feature. So I did it myself in this commit Again, I am sorry I did not gave you the opportunity to contribute. I know the feeling of excitement when you work is recognized. Maybe next time. |
|
@aradzie haha cool |
