Add revert reasons to proxies #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #490.
sohkai
reviewed
Oct 16, 2018
sohkai
reviewed
Oct 16, 2018
sohkai
reviewed
Oct 16, 2018
apps/vault/contracts/Vault.sol
Outdated
| @@ -50,12 +58,12 @@ contract Vault is EtherTokenConstant, AragonApp, DepositableStorage { | |||
| external | |||
| authP(TRANSFER_ROLE, arr(_token, _to, _value)) | |||
| { | |||
| require(_value > 0); | |||
| require(_value > 0, ERROR_TRANSFER_VALUE_ZERO); | |||
|
|
|||
| if (_token == ETH) { | |||
| _to.transfer(_value); | |||
There was a problem hiding this comment.
Wondering if we should use a require(_to.send(_value)) here so we can customize the error message.
sohkai
reviewed
Oct 16, 2018
apps/vault/contracts/Vault.sol
Outdated
| string private constant ERROR_TRANSFER_VALUE_ZERO = "VAULT_TRANSFER_VALUE_ZERO"; | ||
| string private constant ERROR_VALUE_MISMATCH = "VAULT_VALUE_MISMATCH"; | ||
| string private constant TOKEN_TRANSFER_FROM_REVERTED = "VAULT_TOKEN_TRANSFER_FROM_REVERT"; | ||
| string private constant TOKEN_TRANSFER_REVERTED = "VAULT_TOKEN_TRANSFER_REVERTED"; |
There was a problem hiding this comment.
These last two should have the ERROR_ prefix :).
There was a problem hiding this comment.
I was not using the prefix when it's a _REVERT, but I'll add it.
sohkai
reviewed
Oct 16, 2018
| @@ -176,7 +186,7 @@ contract Voting is IForwarder, AragonApp { | |||
| * @param _evmScript Start vote with script | |||
| */ | |||
| function forward(bytes _evmScript) public { | |||
| require(canForward(msg.sender, _evmScript)); | |||
| require(canForward(msg.sender, _evmScript), ERROR_CAN_NOT_FORWARD); | |||
| _newVote(_evmScript, "", true, true); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can't comment far enough down, but there should be a message for the require(vote_.totalVoters > 0) later.
There was a problem hiding this comment.
Oh, I missed that one when merging master, thanks!
sohkai
reviewed
Oct 16, 2018
apps/voting/contracts/Voting.sol
Outdated
| @@ -162,7 +172,7 @@ contract Voting is IForwarder, AragonApp { | |||
| * @param _voteId Id for vote | |||
| */ | |||
| function executeVote(uint256 _voteId) external voteExists(_voteId) { | |||
| require(canExecute(_voteId)); | |||
| require(canExecute(_voteId), ERROR_CAN_NOT_EXCUTE); | |||
Address PR #495 comments.
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
* Add revert reasons to proxies Closes aragon#490. * Add revert reasons to proxies Address PR aragon#495 comments. * Fix
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* Add revert reasons to proxies Closes aragon#490. * Add revert reasons to proxies Address PR aragon#495 comments. * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #490.