-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas reporter #71
Gas reporter #71
Conversation
Not sure if the package-lock.json files should have been included in this PR. Seems like I should remove those from this PR. |
Why is that? |
Just seems like a lot of changes. Have also seen some debates in other repos to not include the lock files in commits. Guess that is just preference though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Please add script to package.json in every app and in the root package for running it with lerna: https://github.com/aragon/aragonOS/pull/185/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R7
Added the test to all apps and is enable to run by lerna. Was not able to get it to properly run due to the compilation errors that are occurring during tests. |
Hi @cpurta! Yes we are using lock files in aragon/aragon and aragon/ui, but we are prioritizing Ideally, I think we should support both until the two projects agree on a common format, but keeping them in sync need to be done manually, which is too annoying IMO. So, to answer the question: yes, having a |
@bpierre, thanks for the clarification. |
Gas reporter
Add
eth-gas-reporter
for app testing. Creating a PR in aragon-core so that the truffle-config file needed will be imported when that is merged.Resolves #65