-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voting: add apps filter #967
Conversation
@sohkai re your comments:
I don't see the filter header in that image, so just to be on the safe side: it should say 'Apps' on the top of the panel using text-style |
Yeah, I'm not sure what the most clear way of expressing this will be. On an org with multiple voting apps (e.g.
Would be quite confusing. |
Discussed offline for filter options: in the case of multiple app instances, the filter items should display the custom label. If custom labels are not available, we'll use |
@dizzypaty I'll work on the other dropdown-related issues in their own issue. This is how the dropdown current looks like (imagine there are multiple apps installed for Voting and Tokens):
Added 15e714f to detect multiple app instances before displaying identifiers. |
…ifier in app filter
Adds the apps filters to Voting. Requires a new release of all aragonAPI libraries.
@dizzypaty I've added two mandatory options to this list:
Voting (this)
: selects votes without a script (i.e. polls)External
: selects votes to target contracts outside of the current organizationThe dropdown list is sorted alphabetically by name. None are currently loaded, but identifiers (no custom labels yet) will be shown as, e.g.
Tokens (ANT)
.I was thinking it'd be nice to have external, but it's unlikely someone would be using the Voting app to make external calls at this point (they'd likely just be making interactions against an installed Agent app), so we can remove it.