Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra 0x on keccak256 calls #861

Closed
macor161 opened this issue Nov 1, 2019 · 0 comments 路 Fixed by #862 or #855
Closed

Extra 0x on keccak256 calls #861

macor161 opened this issue Nov 1, 2019 · 0 comments 路 Fixed by #862 or #855
Assignees
@macor161
Labels
馃悰 bug An unexpected behavior of the API

Comments

@macor161
Copy link
Contributor

macor161 commented Nov 1, 2019

馃悰 Bug Report

Since the migration from js-sha3 to web3.utils, adding an extra 0x in front of keccak256 calls (e.g. here) is no longer necessary. We should remove them as the result is invalid hexadecimal (0x0x...).
@macor161 macor161 self-assigned this Nov 1, 2019
@macor161 macor161 added the 馃悰 bug An unexpected behavior of the API label Nov 1, 2019
@0xGabi 0xGabi mentioned this issue Nov 1, 2019
Merged
1 task
@macor161 macor161 mentioned this issue Nov 1, 2019
Merged
@0xGabi 0xGabi mentioned this issue Nov 5, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macor161 macor161

Labels
馃悰 bug An unexpected behavior of the API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra 0x on keccak256 calls
Fix e2e-test on develop 0xGabi/aragon-cli
1 participant
@macor161