Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e-test on master #873

Merged
merged 10 commits into from
Nov 5, 2019
Merged

Fix e2e-test on master #873

merged 10 commits into from
Nov 5, 2019

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Nov 5, 2019 •
edited
Loading

馃 Pull Request

Currently the CI is broke. This PR will fix that.

I have to skip two test:

  1. create-aragon-app that test the generation of a new boilerplate environment
  2. aragon run cause it dependent of having a environment setup with the previous test

TODO:

  • Fix the above test

This PR also fixes #861

鉁旓笍 PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@0xGabi 0xGabi requested a review from macor161 November 5, 2019 19:08
@0xGabi 0xGabi merged commit 1b9ea44 into aragon:master Nov 5, 2019
@0xGabi 0xGabi deleted the fix-ci branch November 5, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernelwhisperer kernelwhisperer Awaiting requested review from kernelwhisperer

@macor161 macor161 Awaiting requested review from macor161

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xGabi @macor161