Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract away the keccak256 function #914

Closed
macor161 opened this issue Nov 14, 2019 · 1 comment
Closed

Abstract away the keccak256 function #914

macor161 opened this issue Nov 14, 2019 · 1 comment
Labels
🙏 good first issue An easy issue for a new contributor 🛠️ toolkit Toolkit for accessing Aragon utilities programmatically.

Comments

@macor161
Copy link
Contributor

🚀 Feature

The keccak256 functions from web3.utils and js-sha3 don't have the exact same behavior. The former outputs a string with 0x and the latter without 0x. It would be interesting to abstract keccak256 into our own function in case we have to migrate again to a different implementation.

Motivation

It would make it easier and less error prone to switch to another keccak256 library in the future.
@macor161 macor161 added 🙏 good first issue An easy issue for a new contributor 🛠️ toolkit Toolkit for accessing Aragon utilities programmatically. labels Nov 14, 2019
@macor161 macor161 mentioned this issue Nov 14, 2019
Merged
@0xGabi
Copy link
Contributor

0xGabi commented Jan 10, 2020

Solved with #870

@0xGabi 0xGabi closed this as completed Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙏 good first issue An easy issue for a new contributor 🛠️ toolkit Toolkit for accessing Aragon utilities programmatically.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macor161 @0xGabi