Extracts logic from apm commands: extract-functions command #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theethernaut
force-pushed
the
sdk-v7-refactor-apm-extract-functions
branch
from
61b939c
to
43c2497
Compare
theethernaut
changed the title
14 tasks
theethernaut
force-pushed
the
sdk-v7-refactor-apm-extract-functions
branch
from
43c2497
to
eea1680
Compare
macor161
suggested changes
Nov 5, 2019
0xGabi
requested review from
dapplion
and removed request for
kernelwhisperer
dapplion
suggested changes
Nov 14, 2019
| @@ -89,11 +89,11 @@ | |||
| "devDependencies": { | |||
| "@aragon/apps-agent": "^2.0.0", | |||
| "@aragon/apps-finance": "^3.0.0", | |||
| "@aragon/apps-payroll": "^1.0.0", | |||
There was a problem hiding this comment.
Avoid unnecessary changes in other sections of the package.json to prevent git conflicts
There was a problem hiding this comment.
Agree that we should avoid changes unrelated to the PR. I left it there because it will probably conflict with develop if I remove it.
delete-merged-branch
bot
deleted the
sdk-v7-refactor-apm-extract-functions
branch
macor161
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Enabling verbose in AVA tests * Review: Extracts logic from apm commands: info command (#898) * Extracts logic from apm commands: extract-functions command (#870) * Extracts logic from apm commands: versions command (#891) * Extracts logic from apm commands: packages command (#892) * Extracts logic from apm commands: grant command (#902) * Fix test import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
Sub PR of #871