Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @aragon/toolkit examples folder #1482

Merged
merged 2 commits into from Feb 18, 2020

Conversation

sembrestels
Copy link

@sembrestels sembrestels commented Feb 17, 2020

馃 Pull Request Description

Added atomicPayments, mintAndBurn, permissions, and swapSaiToDai scripts to the aragon-toolkit examples folder.

Rational

It is always good to document @aragon/toolkit with some real-life examples of its capabilities.

馃毃 Test instructions

You can change the script parameters in their respective JSON files (read README to know how), and run the scripts using node index.js.

鉁旓笍 PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@welcome
Copy link

welcome bot commented Feb 17, 2020

Thanks for opening this pull request! Someone will review it soon 馃攳

Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this @sembrestels 馃檹

@0xGabi 0xGabi merged commit 6efdcf4 into aragon:develop Feb 18, 2020
@welcome
Copy link

welcome bot commented Feb 18, 2020

Congrats on merging your first pull request! Aragon is proud of you 馃
Eagle gif

0xGabi pushed a commit that referenced this pull request Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants