Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing gasPrice parameter #1708

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Add missing gasPrice parameter #1708

merged 8 commits into from
Jun 9, 2020

Conversation

macor161
Copy link
Contributor

@macor161 macor161 commented Jun 2, 2020

馃 Pull Request Description

Adds missing gasPrice parameter to:

  • dao act
  • dao new
  • dao exec

sohkai
sohkai approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macor161 macor161 marked this pull request as ready for review June 9, 2020 00:23
@macor161
Copy link
Contributor Author

macor161 commented Jun 9, 2020

So after reverting the last dependency updates one by one, it turns out the ipfs-http-client was the problem. Still not sure why tests from the PR were not failing.

@macor161 macor161 merged commit 3ce51fe into master Jun 9, 2020
@macor161 macor161 deleted the add-gasprice branch June 9, 2020 00:25
@sohkai
Copy link
Contributor

sohkai commented Jun 9, 2020 •
edited

Interesting, perhaps we can have a look at the release notes of that package. We were having an issue fetching the artifacts off of IPFS in the tests, right?

Maybe v44 requires IPFS 0.5/0.6 or something?

@macor161
Copy link
Contributor Author

macor161 commented Jun 9, 2020

We were having an issue fetching the artifacts off of IPFS in the tests, right?

Mostly yes, but sometimes other unrelated tests as well.

Maybe v44 requires IPFS 0.5/0.6 or something?

Ah maybe! I will look into this.

macor161 added a commit that referenced this pull request Jul 1, 2020
@macor161
Add missing gasPrice parameter (#1708)
43bbeda 
* Add missing gas-price parameter to act, exec and new commands
@macor161 macor161 mentioned this pull request Jul 1, 2020
Merged
macor161 added a commit that referenced this pull request Jul 2, 2020
@macor161
Stable branch fixes (#1739)
de81925 
* Add eth-json-rpc-filters dependency
* Client hotfix (#1737)
* Temporarily use Gabi's client hotfix
* Increase devchain timeout to 5m
* Add missing gasPrice parameter (#1708)
* Add missing gas-price parameter to act, exec and new commands
* Bump @aragon/cli to v7.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macor161 @sohkai