Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARA-818 jest tests #1840

Merged
merged 12 commits into from
Mar 29, 2021
Merged

ARA-818 jest tests #1840

merged 12 commits into from
Mar 29, 2021

Conversation

c0rv0s
Copy link
Contributor

@c0rv0s c0rv0s commented Mar 24, 2021

🦅 Pull Request Description

Updates tests to use Jest instead of Ava

Rational

#1050

🚨 Test instructions

No difference

@linear
Copy link

linear bot commented Mar 24, 2021

ARA-818 Some tests written in Jest pass when run individually but not when run as a suite

github issue #1832

Bug Report

In the branch issue-1050/update-tests when running all tests via yarn test in one of the packages many of the tests will fail including test/dao/dao-token-new.test.js and test/dao/dao-id-assign.test.js but when run individually they pass

Have you read the Contributing Guidelines on issues?

  • [. ] Yes

To Reproduce

  1. switch to branch issue-1050/update-tests
  2. start the pretest
  3. yarn test in packages/cli, test will fail
  4. npx jest test/dao/dao-id-assign.test.js, test will pass

Expected behavior

Test should pass whether it is being run on its own or in the batch

Actual Behavior

Tests failed in the full suite run but passed on their own

Context

Mainnet or testnet?

Devchain

Organization

(Enter the URL or ENS name of your organization.)

Environment

  • OS and OS version: macOS 11.2.2
  • Browser and browser version: N/A
  • Add any other context about the problem here.

@c0rv0s c0rv0s marked this pull request as ready for review March 24, 2021 21:25
@c0rv0s c0rv0s changed the title Ara 818 jest tests ARA-818 jest tests Mar 24, 2021
Copy link
Contributor

@nestorbe nestorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@nestorbe nestorbe merged commit 2bb3695 into master Mar 29, 2021
@nestorbe nestorbe deleted the ARA-818-jest-tests branch March 29, 2021 22:06
@welcome
Copy link

welcome bot commented Mar 29, 2021

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants