Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure configured wrapper port is exposed to Aragon client #201

Merged
merged 1 commit into from Sep 25, 2018
Merged

Ensure configured wrapper port is exposed to Aragon client #201

merged 1 commit into from Sep 25, 2018

Commits on Sep 14, 2018

  1. fix(commands/run): ensure configured client wrapper port is used 

    Prior to this commit, using `WRAPPER_PORT` and changing it to a users needs
didn't have any effect as

a) the port has never been passed down to the Aragon client
b) Aragon client's script isn't prepared to retrieve values from the environment

This commit ensures that the port is set as an environment variable,
enabling Aragon client to take advantage of it.

Fixes aragon#198
    @0x-r4bbit
    0x-r4bbit committed Sep 14, 2018
    Copy the full SHA
    7af356a View commit details
    Browse the repository at this point in the history