Add gas-price global option #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelwhisperer
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Fetch to gasStationAPI is not working, might be some CORS issue involved
I don't think is possible to do it in default or coerce because they expect synchronous functions..
We can move it to an async middlewave, but... I'm not a big fan of adding this feature because it will get triggered all the time, even when doing aragon -v and because it's a bit magical (aragon --help says 10 gwei, but it's actually dynamic).
I think it would be nicer if we prompt the user right before sending the transaction and ask them if they want to use safeLow, default, fastest, custom, etc.
…into feat/gas-price-option
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request
closes #499
Include new
--gas-priceoption to manually setup the gas price.Small fix to include agent, survey and payroll as known apps to display instead of appId hash.
TODO (New issue #631):
Fetch to
gasStationAPIis not working, might be some CORS issue involved 🤔Prompt the user before signing the tx