Extract logic from "dao apps" and "dao new" #955
Conversation
|
hmm.. there is currently a weird Travis error on node 9 and 10. I'm looking into this. |
Codecov Report
@@ Coverage Diff @@
## develop #955 +/- ##
===========================================
+ Coverage 20.22% 21.35% +1.12%
===========================================
Files 106 108 +2
Lines 2442 2440 -2
===========================================
+ Hits 494 521 +27
+ Misses 1948 1919 -29
Continue to review full report at Codecov.
|
| from: ctx.accounts[0], | ||
| gas: await getRecommendedGasLimit(web3, estimatedGas), | ||
| task: async ctx => { | ||
| console.log('registry: ', apmOptions.ensRegistryAddress) |
There was a problem hiding this comment.
Good catch thanks! 😄
| deployEvent, | ||
| gasPrice, | ||
| }) { | ||
| const template = |
There was a problem hiding this comment.
I think this part is a bit awkward. Is been more and more clear that we need a clear distinction of how we handle the aragonPM information. Probably something to look a bit more in detail on current iteration after we merge this PR.
There was a problem hiding this comment.
I agree 💯
The templateInstance was originally used here https://github.com/aragon/aragon-cli/blob/develop/packages/aragon-cli/src/commands/run.js#L371 but we'll probably be able to simplify things once we start refactoring the run command.
Co-Authored-By: Gabriel Garcia <gabrielpk.18@gmail.com>
|
@macor161 According to AVA's documentation, most of the usage of |
@dapplion Ah I didn't know that thanks! It is fixed now. |
|
Also note that this might be an indication that we have a hole in the tests. |
@ajsantander hmm strange it's working here but something is clearly wrong then. I will review this furthermore. |
macor161
changed the title
0xGabi
changed the title
|
@0xGabi Thanks a lot!! 🙂 |
🦅 Pull Request
Extract logic from
dao appsanddao newto thelibfolder.Supersedes #944
Part of the integration tests are dependent on IPFS. They will therefore be added once IPFS is included.
🚨 Test instructions
dao newdao apps