-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ConsoleReporter #965
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #965 +/- ##
===========================================
- Coverage 19.89% 19.78% -0.11%
===========================================
Files 104 111 +7
Lines 2523 2537 +14
===========================================
Hits 502 502
- Misses 2021 2035 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!! I used aragen 5.4.1
because there is currently a bug in 5.4.2
and I moved the middlewares after AragonReporter
. I'm not entirely convinced the reporter should configure yargs options though 馃 In any case we can discuss this in the next iteration.
Awesome job! 馃挴
update_configs: | ||
- package_manager: "javascript" | ||
directory: "/" | ||
update_schedule: "weekly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 鉂わ笍 This will definitely reduce the noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
馃 Pull Request
network
option@babel/plugin-proposal-object-rest-spread
since is supported on Nodejs since 8.3.0babel
tocli-utils
Part of #858
馃毃 Test instructions
鉁旓笍 PR Todo