Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ConsoleReporter #965

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Refactor ConsoleReporter #965

merged 6 commits into from
Nov 27, 2019

Conversation

kernelwhisperer
Copy link
Contributor

馃 Pull Request

  • Removed the deprecated network option
  • Removed @babel/plugin-proposal-object-rest-spread since is supported on Nodejs since 8.3.0
  • Added babel to cli-utils

Part of #858

馃毃 Test instructions

鉁旓笍 PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #965 into develop will decrease coverage by 0.1%.
The diff coverage is 1.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
- Coverage    19.89%   19.78%   -0.11%     
===========================================
  Files          104      111       +7     
  Lines         2523     2537      +14     
===========================================
  Hits           502      502              
- Misses        2021     2035      +14
Impacted Files Coverage 螖
...ackages/cli-utils/src/reporters/ConsoleReporter.js 0% <0%> (酶)
packages/cli-utils/src/reporters/ReporterIcons.js 0% <0%> (酶)
packages/cli-utils/src/AragonReporter.js 0% <0%> (酶)
packages/aragon-cli/src/cli.js 0% <0%> (酶) 猬嗭笍
packages/create-aragon-app/src/cli.js 0% <0%> (酶) 猬嗭笍
...ages/aragon-cli/scripts/setup-integration-tests.js 100% <100%> (酶) 猬嗭笍
packages/cli-utils/src/helpers/default-apm.js 0% <0%> (酶)
packages/cli-utils/src/util.js 0% <0%> (酶)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2619328...0bcb69d. Read the comment docs.

Copy link
Contributor

@macor161 macor161 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! I used aragen 5.4.1 because there is currently a bug in 5.4.2 and I moved the middlewares after AragonReporter. I'm not entirely convinced the reporter should configure yargs options though 馃 In any case we can discuss this in the next iteration.
Awesome job! 馃挴

update_configs:
- package_manager: "javascript"
directory: "/"
update_schedule: "weekly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 鉂わ笍 This will definitely reduce the noise.

Copy link
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macor161 macor161 merged commit 956208e into develop Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the refactor/aragon-reporter branch November 27, 2019 01:39
@0xGabi 0xGabi mentioned this pull request Nov 29, 2019
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants