test: fix solidity test runner so it actually errors

aragon · Apr 3, 2019 · 5c70c46 · 5c70c46
1 parent d1cd633
commit 5c70c46
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 5 deletions.
diff --git a/test/helpers/decodeEvent.js b/test/helpers/decodeEvent.js
@@ -6,7 +6,7 @@ module.exports = {
         const eventSignature = abi.encodeEventSignature(eventAbi)
         const eventLogs = receipt.logs.filter(l => l.topics[0] === eventSignature)
         return eventLogs.map(log => {
-            log.event = abi.name
+            log.event = eventAbi.name
             log.args = abi.decodeLog(eventAbi.inputs, log.data, log.topics.slice(1))
             return log
         })

diff --git a/test/helpers/runSolidityTest.js b/test/helpers/runSolidityTest.js
@@ -1,15 +1,38 @@
+const { decodeEventsOfType } = require('./decodeEvent')
+
+const ASSERT_LIB_EVENTS_ABI = [
+  {
+    "anonymous": false,
+    "inputs": [
+      {
+        "indexed": true,
+        "name": "result",
+        "type": "bool"
+      },
+      {
+        "indexed": false,
+        "name": "message",
+        "type": "string"
+      }
+    ],
+    "name": "TestEvent",
+    "type": "event"
+  },
+]
+
 const HOOKS_MAP = {
   beforeAll: 'before',
   beforeEach: 'beforeEach',
   afterEach: 'afterEach',
   afterAll: 'afterAll',
 }
 
-const processResult = receipt => {
-  if (!receipt) {
+const processResult = txReceipt => {
+  if (!txReceipt || !txReceipt.receipt) {
     return
   }
-  receipt.logs.forEach(log => {
+  const decodedLogs = decodeEventsOfType(txReceipt.receipt, ASSERT_LIB_EVENTS_ABI, 'TestEvent')
+  decodedLogs.forEach(log => {
     if (log.event === 'TestEvent' && log.args.result !== true) {
       throw new Error(log.args.message)
     }
@@ -27,7 +50,7 @@ const linkLib = async (contract, libName) => {
 
   const prefix = underscores(PREFIX_UNDERSCORES)
   const suffix = underscores(ADDR_LENGTH - PREFIX_UNDERSCORES - libName.length)
-  
+
   const libPlaceholder = `${prefix}${libName}${suffix}`
 
   const lib = await artifacts.require(libName).new()