Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the tense of events (nitpick) #89

Closed
onbjerg opened this issue Aug 18, 2017 · 5 comments
Closed

Standardize the tense of events (nitpick) #89

onbjerg opened this issue Aug 18, 2017 · 5 comments

Comments

@onbjerg
Copy link
Contributor

onbjerg commented Aug 18, 2017

Some events are in the past tense (e.g. KernelReplaced) and some are not (e.g. Register and Deregister). Making them all in the same tense would be nice.

@ETeissonniere
Copy link

If no one is working on that, I take it

@izqui
Copy link
Contributor

izqui commented Aug 23, 2017 via email

@ETeissonniere
Copy link

ETeissonniere commented Aug 23, 2017

@izqui even the ones in MinimeToken? Or do you prefer to keep them as it is?

@ETeissonniere
Copy link

I first started by making all events to the past tense, but if we look at the ezeppelin lib they seems to use present tense, maybe we should switch to present then

@ETeissonniere
Copy link

I think past tense would seems nicer but for the sake of interoperation with third parties library, present would be nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants