-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the tense of events (nitpick) #89
Labels
Comments
If no one is working on that, I take it |
Nice! Lets make them all past tense IMO
El mié., 23 ago. 2017 a las 10:20, Eliott T. (<notifications@github.com>)
escribió:
… If no one is working on that, I take it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#89 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbTYEHD8u455gr8D-2tx5pNlQDbb6zRks5sa-DbgaJpZM4O7yVR>
.
|
@izqui even the ones in MinimeToken? Or do you prefer to keep them as it is? |
I first started by making all events to the past tense, but if we look at the ezeppelin lib they seems to use present tense, maybe we should switch to present then |
I think past tense would seems nicer but for the sake of interoperation with third parties library, present would be nicer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some events are in the past tense (e.g.
KernelReplaced
) and some are not (e.g.Register
andDeregister
). Making them all in the same tense would be nice.The text was updated successfully, but these errors were encountered: