Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove babel #154

Merged
merged 2 commits into from
Nov 20, 2017
Merged

Remove babel #154

merged 2 commits into from
Nov 20, 2017

Conversation

onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Nov 19, 2017

Closes #153

@onbjerg onbjerg requested a review from izqui November 19, 2017 02:09
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.699% when pulling f03aca7 on remove-babel into b479ee8 on dev.

@izqui
Copy link
Contributor

izqui commented Nov 20, 2017

Awesome!

@izqui izqui mentioned this pull request Nov 20, 2017
Closed
@izqui izqui modified the milestone: v0.4 alpha Nov 20, 2017
@onbjerg
Copy link
Contributor Author

onbjerg commented Nov 20, 2017

Merge when the time is right 👌

@izqui izqui merged commit 4da9dcf into dev Nov 20, 2017
@izqui izqui deleted the remove-babel branch November 20, 2017 14:15
@sohkai
Copy link
Contributor

sohkai commented Nov 20, 2017

So it turns out that import and export don't work transparently yet in Node 9 (not sure if .mjs is necessary for modules); just keep this in mind when writing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onbjerg @coveralls @izqui @sohkai