Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile contracts on pre-publish #241

Merged
merged 4 commits into from
Feb 28, 2018
Merged

Compile contracts on pre-publish #241

merged 4 commits into from
Feb 28, 2018

Conversation

cpurta
Copy link
Contributor

@cpurta cpurta commented Feb 27, 2018

Runs the truffle compile --all command as a part of a pre-publish script. Using the prepublishOnly script so that contracts on only compile before publish and not when running npm install.

Confirmed that contracts are compiled and put into the build/contracts folder which is then published.

Resolves #213

@coveralls
Copy link

coveralls commented Feb 27, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.489% when pulling 4cb0b3e on cpurta:abi-prepublish into aefb4b5 on aragon:dev.

sohkai
sohkai approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just published v3.0.5 with this in, and it worked well!

@sohkai sohkai merged commit 7f564bc into aragon:dev Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpurta @coveralls @sohkai