Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require minimum return data from EVMScript executors to prevent selfdestructs #255

Merged
merged 2 commits into from Mar 27, 2018
Merged

Require minimum return data from EVMScript executors to prevent selfdestructs #255

merged 2 commits into from Mar 27, 2018

Conversation

izqui
Copy link
Contributor

@izqui izqui commented Mar 25, 2018

Close #250

@izqui izqui requested a review from sohkai March 25, 2018 15:41
@izqui
Copy link
Contributor Author

izqui commented Mar 26, 2018

CI doing stupid stuff. Tests are passing locally

@bingen
Copy link
Contributor

bingen commented Mar 26, 2018

Yes, I had the exact same problem a while ago with one of my PRs. Following your advice and just restarting it did the trick ;-)

@coveralls
Copy link

coveralls commented Mar 26, 2018 •
edited

Coverage Status

Coverage increased (+0.01%) to 99.49% when pulling 3a92325 on evmscript-min-return into 053fb10 on dev.

sohkai
sohkai approved these changes Mar 26, 2018
View reviewed changes
test/evm_script.js
})

it('executes mock executor', async () => {
await executor.execute('0x00000004')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could check that the result is actually bytes(1)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executor.execute doesn't return anything, it would require some changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executor.execute doesn't return anything, it would require some changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn, ok. Let's not worry about it then.

@izqui izqui merged commit b4b45b8 into dev Mar 27, 2018
@izqui izqui deleted the evmscript-min-return branch March 27, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
audit: whg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@izqui @bingen @coveralls @sohkai