Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL: log whether a permission was set with parameters #362

Merged
merged 5 commits into from
Aug 15, 2018
Merged

ACL: log whether a permission was set with parameters #362

merged 5 commits into from
Aug 15, 2018

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jul 16, 2018

Fixes #212.

@sohkai sohkai requested review from izqui and bingen July 16, 2018 02:27
@sohkai
Copy link
Contributor Author

sohkai commented Jul 25, 2018

So just wanted to highlight that this change will be a headache for the frontend migration.

The new event signature means that aragon.js won't know about old DAOs' ACL's setPermission event.

@sohkai
Copy link
Contributor Author

sohkai commented Jul 27, 2018

I've since changed this to instead emit another event, so that it's backwards compatible.

@coveralls
Copy link

coveralls commented Jul 27, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 99.01% when pulling a7d0997 on acl-log-set-params into 898310f on dev.

@sohkai sohkai merged commit 796ebfd into dev Aug 15, 2018
@sohkai sohkai deleted the acl-log-set-params branch August 15, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

@bingen bingen bingen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sohkai @coveralls @izqui @bingen