EVMScriptExecutor: add type for off-chain reading #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
changed the title
izqui
approved these changes
Aug 22, 2018
| @@ -9,6 +9,8 @@ import "../IEVMScriptExecutor.sol"; | |||
| contract CallsScript is IEVMScriptExecutor { | |||
| using ScriptHelpers for bytes; | |||
|
|
|||
| bytes32 constant internal EXECUTOR_TYPE = keccak256("CALLSCRIPT"); | |||
There was a problem hiding this comment.
Should be CALLSSCRIPT or CALLS_SCRIPT which will read nicer. Also from what I'm testing hardcoding the hash results in a 4k less gas when creating the contract
|
Bytecode size: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting worried that we always assume in
aragon.jsthat the first executor in an organization'sEVMScriptRegistryis the callscript executor, rather than doing an on-chain confirmation.TODO: