Kernel: allow initializing app proxies on overloaded newAppInstance #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingen
approved these changes
Sep 3, 2018
sohkai
approved these changes
Sep 3, 2018
contracts/kernel/Kernel.sol
Outdated
| @@ -70,15 +70,16 @@ contract Kernel is IKernel, KernelStorage, Petrifiable, IsContract, VaultRecover | |||
| * @param _setDefault Whether the app proxy app is the default one. | |||
| * Useful when the Kernel needs to know of an instance of a particular app, | |||
| * like Vault for escape hatch mechanism. | |||
| * @param _initializePayload Payload for call made by the proxy on its constructor to initialize | |||
There was a problem hiding this comment.
Thoughts on this going before setDefault, since it's part of the proxy initialization?
There was a problem hiding this comment.
I have no hard feelings either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppProxyFactoryexposes the ability to pass an initialization payload that app proxies execute on their constructor. This PR exposes this ability at the Kernel level, so apps can be atomically initialized when they are created.