Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change devnet (docker image) network id #447

Merged
merged 1 commit into from Oct 24, 2018
Merged

Change devnet (docker image) network id #447

merged 1 commit into from Oct 24, 2018

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Oct 24, 2018

Needed for dao-kits, to automatically choose network from scripts. Right now it's overlapping with rpc.

@bingen bingen self-assigned this Oct 24, 2018
@bingen bingen requested review from izqui and sohkai October 24, 2018 15:07
@bingen bingen mentioned this pull request Oct 24, 2018
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.765% when pulling d9de98d on devnet_network_id into 889627d on dev.

@bingen bingen merged commit e99180a into dev Oct 24, 2018
@sohkai sohkai deleted the devnet_network_id branch October 25, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

@sohkai sohkai Awaiting requested review from sohkai

Assignees

@bingen bingen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bingen @coveralls @izqui