Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore EVMScriptRegistryFactory: remove unused AppProxyFactory base contract #452

Merged
merged 1 commit into from
Oct 28, 2018
Merged

chore EVMScriptRegistryFactory: remove unused AppProxyFactory base contract #452

merged 1 commit into from
Oct 28, 2018

Conversation

izqui
Copy link
Contributor

@izqui izqui commented Oct 28, 2018

We forgot to remove it when the factory started using dao.newPinnedAppInstance to create instances.

@izqui izqui requested review from bingen and sohkai October 28, 2018 13:45
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.76% when pulling a8a45c9 on clean-evmscriptregistryfactory into b5c0a98 on dev.

sohkai
sohkai approved these changes Oct 28, 2018
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@izqui izqui merged commit 2a008e4 into dev Oct 28, 2018
@izqui izqui deleted the clean-evmscriptregistryfactory branch October 28, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingen bingen bingen approved these changes

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@izqui @coveralls @bingen @sohkai