Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL: update user/who parameters to who/grantee #589

Merged
merged 3 commits into from
Jul 2, 2020
Merged

ACL: update user/who parameters to who/grantee #589

merged 3 commits into from
Jul 2, 2020

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jul 1, 2020

Updates the parameter names for the new user/who concepts for ACLOracleV2 to be who/grantee.

I wanted to keep who the same as before, as we use who as the original sender everywhere else (e.g. hasPermission()).

@sohkai sohkai requested a review from facuspagnuolo July 1, 2020 22:35
@auto-assign auto-assign bot requested a review from izqui July 1, 2020 22:36
Base automatically changed from acl_enhancements to next July 1, 2020 23:15
@facuspagnuolo
Copy link
Contributor

Let's rebase this one against next to facilitate the review 🙏

@sohkai
Copy link
Contributor Author

sohkai commented Jul 2, 2020

Updated now!

@coveralls
Copy link

coveralls commented Jul 2, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 98.862% when pulling 70378aa on acl_enhancements_rename into a70d806 on next.

facuspagnuolo
facuspagnuolo approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer! Let's fix the linter and merge :)

@facuspagnuolo facuspagnuolo merged commit e6ea55f into next Jul 2, 2020
@facuspagnuolo facuspagnuolo deleted the acl_enhancements_rename branch July 2, 2020 14:45
facuspagnuolo added a commit that referenced this pull request Aug 3, 2020
@facuspagnuolo
Revert "ACL: update user/who parameters to who/grantee (#589)"
74e5b85 
This reverts commit e6ea55f.
facuspagnuolo added a commit that referenced this pull request Aug 4, 2020
@facuspagnuolo
ACL: Rollback v2 changes (#606)
d676f59 
* Revert "ACL: update user/who parameters to who/grantee (#589)"

This reverts commit e6ea55f.

* Revert "ACL: Multiple enhancements (#584)"

This reverts commit a70d806.

* Disputable: Rollback ACL v2 support for Agreement mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facuspagnuolo facuspagnuolo facuspagnuolo approved these changes

@izqui izqui Awaiting requested review from izqui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sohkai @facuspagnuolo @coveralls