Disputable: Add Registry sample app #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Aug 5, 2020
| @@ -0,0 +1,232 @@ | |||
| /* | |||
There was a problem hiding this comment.
Perhaps let's move this to a top level examples/ folder; I think contracts should only contain contracts we want to expose to others (especially in the npm package).
There was a problem hiding this comment.
I like the idea! Addressed now, let me know your thoughts :)
There was a problem hiding this comment.
Ah, I was actually meaning even outside of the contracts/ folder so as to not confuse any one! Do you think it would still be worth leaving it in the contracts/examples folder?
There was a problem hiding this comment.
Sounds better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this sample app from the Agreement app subrepo