Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use buidler #615

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Chore: Use buidler #615

merged 4 commits into from
Aug 25, 2020

Conversation

facuspagnuolo
Copy link
Contributor

No description provided.

@facuspagnuolo facuspagnuolo self-assigned this Aug 25, 2020
@auto-assign auto-assign bot requested a review from izqui August 25, 2020 13:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (next@847269c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #615   +/-   ##
=======================================
  Coverage        ?   99.27%           
=======================================
  Files           ?       36           
  Lines           ?      555           
  Branches        ?       74           
=======================================
  Hits            ?      551           
  Misses          ?        4           
  Partials        ?        0           
Flag Coverage Δ
#unittests 99.27% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847269c...78d9cd4. Read the comment docs.


contract.bytecode = contract.bytecode.replace(new RegExp(libPlaceholder, 'g'), libAddr)
const library = await artifacts.require(libName).new()
await contract.link(library)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also enabled this repo on the codecov github app!

@facuspagnuolo facuspagnuolo merged commit ce960e2 into next Aug 25, 2020
@facuspagnuolo facuspagnuolo deleted the use_buidler branch August 25, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants