Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for optimism chain #1816

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Aug 4, 2023

Depends on aragon/use-wallet#281

Aragon should also provide a default node for Optimism

Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey
I left you some comments.
Thanks a lot for the pull request. Please also add at least 1 optimism testnet.

As soon as we updated the use-wallet package please also add the new version to client

src/network-config.js Outdated Show resolved Hide resolved
src/network-config.js Outdated Show resolved Hide resolved
@0xGabi
Copy link
Contributor Author

0xGabi commented Sep 19, 2023

@mathewmeconry thank you for the review. Ping me when the new version of use-wallet is released.

@mathewmeconry
Copy link
Contributor

@0xGabi version v0.15.0 of use-wallet is now published

@0xGabi
Copy link
Contributor Author

0xGabi commented Sep 26, 2023

Hi @mathewmeconry thank you for the help. I just update the package version to the latests use-wallet.

Note that I have to remove the deprecated network ropsten to make it work. Otherwise use-wallet failed because the chain id 3 was not recognized anymore on this version.

@mathewmeconry
Copy link
Contributor

Hey @0xGabi
I am so sorry that it took that long. One last question and then we are good to go 🚀

@mathewmeconry mathewmeconry merged commit 65f70b7 into aragon:develop Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants