Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optimism chain #281

Merged
merged 2 commits into from
Sep 21, 2023
Merged

feat: add optimism chain #281

merged 2 commits into from
Sep 21, 2023

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Aug 4, 2023

Add support for Optimism Mainnet

@0xGabi 0xGabi mentioned this pull request Aug 4, 2023
Merged
mathewmeconry
mathewmeconry suggested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey
Thanks a lot for the pull request. Please also add at least 1 optimism testnet

@0xGabi
Copy link
Contributor Author

0xGabi commented Sep 19, 2023

Hi @mathewmeconry thank you for the review. I added OP Sepolia.

By the way, when working on the next version of use-wallet maybe you should consider remove some of the old connectors that are not widely used anymore: https://github.com/aragon/use-wallet/blob/master/package.json#L24-L32

mathewmeconry
mathewmeconry approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update :)
For now we stopped supporting use-wallet actively. Idk tbh if we ever will continue with it

@mathewmeconry mathewmeconry merged commit 8b10d2f into aragon:master Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewmeconry mathewmeconry mathewmeconry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xGabi @mathewmeconry