Scaffold: 1 – Initial set-up #1
Conversation
src/environment.js
Outdated
| } | ||
|
|
||
| const networkConfig = getNetworkConfig(networkType) | ||
| export const network = networkConfig.settings |
There was a problem hiding this comment.
I think it could be nice to make the network dynamic from the start (maybe as a hook?).
Should we also start from the changes made in Brett’s PR? aragon/client#1485
|
Thanks @bpierre ! I didn’t change anything from the client thinking we wanted to port what we have as quick as possible. I’d love to freshen it all up though and since you agree I’ll go and make the changes! The only thing I’d worry about right now is framer motion, we’ve already written a lot of spring and it might not be worth the time to transition at this particular moment. |
Sounds good! Let’s delay the move to Framer Motion 👍 |
now-mainnet.json
Outdated
| "FORTMATIC_API_KEY": "@aragon-client-fortmatic-api-key", | ||
| "PORTIS_DAPP_ID": "@aragon-client-portis-dapp-id", | ||
| "SENTRY_DSN": "@aragon-client-sentry-dsn" |
There was a problem hiding this comment.
Leaving these as the client secrets for now just to get the deploys working, they will be updated to use scoped env vars via Vercel in a separate improvement.
|
@bpierre @facuspagnuolo – This is ready for review. Now that I know we don't need all of the client baggage I stripped down everything and refreshed the dependencies. Network configuration, routing etc will come in separate improvements. |
| <link rel="icon" type="image/svg+xml" href="icons/favicon.svg" /> | ||
| <link rel="icon" type="image/png" href="icons/favicon.png" /> |
There was a problem hiding this comment.
(Not necessarily in this PR)
We might want to use a higher size than 33x33 for the PNG, maybe 128x128? The SVG should be fine at any size, but it could happen that the SVG size is used to produce the raster image at the same size, so I think we could use 128x128 for both?
There was a problem hiding this comment.
Icon compat is a bit of a minefield :( but this is a good suggestion! Adri is adjusting some graphics too so i'll do them at the same time separately :)
Co-authored-by: Pierre Bertet <hello@pierre.world>
Initial configuration and essentials. Using Parcel because that's tried and tested, perhaps in the future we can use snowpack.