This repository has been archived by the owner on Mar 20, 2020. It is now read-only.
Contracts: Use time helpers for block.timestamp
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
force-pushed
the
use_time_helpers
branch
from
8da7745
to
44db6bb
Compare
sohkai
reviewed
Apr 15, 2019
packages/ppf-contracts/package.json
Outdated
| @@ -24,6 +24,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/aragon/ppf#readme", | |||
| "devDependencies": { | |||
| "@aragon/os": "^4.0.1", | |||
There was a problem hiding this comment.
We should probably pin this
There was a problem hiding this comment.
let's wait for 4.0.2
There was a problem hiding this comment.
4.2.0 has been released :).
izqui
approved these changes
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
TimeHelpersfrom@aragon/osto follow the way we are working with timestamps and block numbers which simplifies things a lot if we need to mock PPF contracts for testing purposes