fix: wrong root permission check (#319)

* fix: corrected wrong where address in test * Revert "fix: corrected wrong where address in test" This reverts commit bab1e58. * fix daoAddress comparison * update version and changelog --------- Co-authored-by: Michael Heuer <michael.heuer@rwth-aachen.de>
aragon · Jan 9, 2024 · 4ee1a00 · 4ee1a00
1 parent d1d1ab7
commit 4ee1a00
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/modules/client/CHANGELOG.md b/modules/client/CHANGELOG.md
@@ -18,6 +18,10 @@ TEMPLATE:
 -->
 
 ## [UPCOMING]
+### Fixed
+- Compare with dao address in `validatePluginUpdateProposal`
+
+## [1.21.1]
 
 ### Changed
 - Chore: Changed voters and approvers count to 1000 from the default value of 100 in Proposal Queries

diff --git a/modules/client/package.json b/modules/client/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@aragon/sdk-client",
   "author": "Aragon Association",
-  "version": "1.21.1",
+  "version": "1.21.2",
   "license": "MIT",
   "main": "dist/index.js",
   "module": "dist/sdk-client.esm.js",

diff --git a/modules/client/src/internal/utils.ts b/modules/client/src/internal/utils.ts
@@ -1033,13 +1033,16 @@ export function validateGrantRootPermissionAction(
     );
   }
   // The action should be sent to the DAO
+  // both come from subgraph so they are already lowercase
   if (action.to !== daoAddress) {
     causes.push(
       PluginUpdateProposalInValidityCause
         .INVALID_GRANT_ROOT_PERMISSION_TO_ADDRESS,
     );
   }
-  if (decodedPermission.where !== daoAddress) {
+  // decodedPermission.where is checksummed so we need to lowercase it
+  // to compare it with the daoAddress because it comes from the subgraph
+  if (decodedPermission.where.toLowerCase() !== daoAddress) {
     causes.push(
       PluginUpdateProposalInValidityCause
         .INVALID_GRANT_ROOT_PERMISSION_WHERE_ADDRESS,