fix: wrong root permission check #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heueristik
changed the title
heueristik
force-pushed
the
hotfix/wrong-root-permission-check
branch
from
1aa5087
to
bab1e58
Compare
This reverts commit bab1e58.
Rekard0
previously approved these changes
Jan 8, 2024
Rekard0
previously approved these changes
Jan 9, 2024
josemarinas
added
the
client-release
|
Rekard0
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The security check failed for a correct update proposal. The problem was not visible in production because none of our plugin updates conducts permission changes and therefore doesn't require
ROOT_PERMISSION_ID.Task ID: OS-936
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the[UPCOMING]title and before the latest version.