fix gas feee estimations (#292)

aragon · Oct 23, 2023 · d2efd90 · d2efd90
1 parent 697caff
commit d2efd90
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/modules/client/CHANGELOG.md b/modules/client/CHANGELOG.md
@@ -18,6 +18,12 @@ TEMPLATE:
 -->
 
 ## [UPCOMING]
+
+### Fixed
+
+- Estimations using `getProvider` instead of `getConnectedSigner` in functions where the identity of the wallet is needed
+
+## [1.16.0]
 ### Added
 
 - Helper for `daoUpdateAction` in `Client`

diff --git a/modules/client/package.json b/modules/client/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@aragon/sdk-client",
   "author": "Aragon Association",
-  "version": "1.16.0",
+  "version": "1.16.1",
   "license": "MIT",
   "main": "dist/index.js",
   "module": "dist/sdk-client.esm.js",

diff --git a/modules/client/src/addresslistVoting/internal/client/estimation.ts b/modules/client/src/addresslistVoting/internal/client/estimation.ts
@@ -30,7 +30,7 @@ export class AddresslistVotingClientEstimation extends ClientCore
   public async createProposal(
     params: CreateMajorityVotingProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const addresslistContract = AddresslistVoting__factory.connect(
       params.pluginAddress,
@@ -71,7 +71,7 @@ export class AddresslistVotingClientEstimation extends ClientCore
   public async voteProposal(
     params: VoteProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const { pluginAddress, id } = decodeProposalId(
       params.proposalId,
@@ -100,7 +100,7 @@ export class AddresslistVotingClientEstimation extends ClientCore
   public async executeProposal(
     proposalId: string,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const { pluginAddress, id } = decodeProposalId(
       proposalId,

diff --git a/modules/client/src/multisig/internal/client/estimation.ts b/modules/client/src/multisig/internal/client/estimation.ts
@@ -29,7 +29,7 @@ export class MultisigClientEstimation extends ClientCore
   public async createProposal(
     params: CreateMultisigProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const multisigContract = Multisig__factory.connect(
       params.pluginAddress,
@@ -69,7 +69,7 @@ export class MultisigClientEstimation extends ClientCore
   public async approveProposal(
     params: ApproveMultisigProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
     const { pluginAddress, id } = decodeProposalId(
       params.proposalId,
     );
@@ -95,7 +95,7 @@ export class MultisigClientEstimation extends ClientCore
   public async executeProposal(
     proposalId: string,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const { pluginAddress, id } = decodeProposalId(
       proposalId,

diff --git a/modules/client/src/tokenVoting/internal/client/estimation.ts b/modules/client/src/tokenVoting/internal/client/estimation.ts
@@ -35,7 +35,7 @@ export class TokenVotingClientEstimation extends ClientCore
   public async createProposal(
     params: CreateMajorityVotingProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const tokenVotingContract = TokenVoting__factory.connect(
       params.pluginAddress,
@@ -75,7 +75,7 @@ export class TokenVotingClientEstimation extends ClientCore
   public async voteProposal(
     params: VoteProposalParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const { pluginAddress, id } = decodeProposalId(
       params.proposalId,
@@ -104,7 +104,7 @@ export class TokenVotingClientEstimation extends ClientCore
   public async executeProposal(
     proposalId: string,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
 
     const { pluginAddress, id } = decodeProposalId(
       proposalId,
@@ -130,7 +130,7 @@ export class TokenVotingClientEstimation extends ClientCore
   public async delegateTokens(
     params: DelegateTokensParams,
   ): Promise<GasFeeEstimation> {
-    const provider = this.web3.getProvider();
+    const provider = this.web3.getConnectedSigner();
     const governanceErc20Contract = GovernanceERC20__factory.connect(
       params.tokenAddress,
       provider,