Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Gas feee estimations #292

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix: Gas feee estimations #292

merged 1 commit into from
Oct 23, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Oct 23, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-772

Type of change

  • Bug fix (non-breaking change which fixes an issue

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added the client-release Publishes the current version of client subpackage on NPM label Oct 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.2% 18.2% Duplication

@josemarinas josemarinas merged commit d2efd90 into develop Oct 23, 2023
7 checks passed
@josemarinas josemarinas deleted the f/OS-772-fix-proposal-gas-estimation branch October 23, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @heueristik