Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for non-DOM environments (Next.js) #699

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Support for non-DOM environments (Next.js) #699

merged 2 commits into from
Jan 10, 2020

Conversation

izqui
Copy link
Contributor

@izqui izqui commented Jan 3, 2020

No description provided.

@welcome
Copy link

welcome bot commented Jan 3, 2020

Thanks for opening this pull request! Someone will review it soon 🔍

@bpierre bpierre marked this pull request as ready for review January 10, 2020 12:58
@auto-assign auto-assign bot requested a review from bpierre January 10, 2020 12:58
@bpierre bpierre requested review from Evalir and removed request for bpierre January 10, 2020 12:59
@bpierre bpierre changed the title SSR support for Next.js Support for non-DOM environments (SSR support for Next.js) Jan 10, 2020
@bpierre bpierre changed the title Support for non-DOM environments (SSR support for Next.js) Support for non-DOM environments (Next.js) Jan 10, 2020
@izqui
Copy link
Contributor Author

izqui commented Jan 10, 2020

Thanks @bpierre!

Evalir
Evalir approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bpierre bpierre merged commit c7b916d into master Jan 10, 2020
@bpierre bpierre deleted the ssr branch January 10, 2020 14:10
@welcome
Copy link

welcome bot commented Jan 10, 2020

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif

@izqui
Copy link
Contributor Author

izqui commented Jan 10, 2020

@WELCOME it was really all Pierre's work at the end but thanks anyway :)

@bpierre bpierre mentioned this pull request Jul 1, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izqui @Evalir @bpierre