Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable support for WalletConnect #17

Closed
sohkai opened this issue Feb 9, 2020 · 5 comments
Closed

Re-enable support for WalletConnect #17

sohkai opened this issue Feb 9, 2020 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sohkai
Copy link
Contributor

sohkai commented Feb 9, 2020

The WalletConnect connector was having some small issues, and has been disabled by default.
@sohkai sohkai added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 9, 2020
@sophiacodes
Copy link

hey @sohkai, I'm curious, what are the small issues with the WalletConnect connector?

@cmagan
Copy link

cmagan commented Apr 21, 2020

@sohkai is there any eta on having the walletConnect back?

@sohkai
Copy link
Contributor Author

sohkai commented Apr 21, 2020

There were previously build issues with wallet connect: https://github.com/aragon/use-wallet/blob/master/src/connectors.js#L17-L21.

This might be as simple as bumping the web3-react connector package's version, so you're welcome to give it a shot and try it on the examples apps included in the repo!

@JamesLefrere
Copy link
Contributor

Should be fixed in #37 :)

@sohkai
Copy link
Contributor Author

sohkai commented Jul 3, 2020

Fixed with #37 and released in 0.6!

@sohkai sohkai closed this as completed Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sophiacodes @sohkai @JamesLefrere @cmagan