-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable WalletConnect and add TypeScript definitions #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good—could we also update the examples to include the WalletConnect connector?
I'll leave it to @andy-hook or @bpierre to check the type definition—🙇♂️ for adding it!
@sohkai Do you have an RPC endpoint to use for the examples? |
@JamesLefrere Not sure I understand; I was thinking of adding WalletConnect to this list (and a similar on in the other examples), and that shouldn't require an RPC endpoint? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe drop the semis but otherwise LGTM! 😄
* Re-enable the WalletConnect connector * Upgrade connectors from `web3-react` * Bug fix: Some providers require a `jsonrpc` and `id` property for all requests; ensure `sendCompat` sends a request with these properties
5c67a98
to
f769810
Compare
@sohkai Yes, I have added them (with empty strings for the RPC urls) to the examples - it's just that it won't be able to connect without a real endpoint, but I guess that's ok for these examples. Also, semis removed 👍 |
@JamesLefrere Ah, I didn't realize that they needed RPC endpoints to work! You can use the endpoints defined here: https://github.com/aragon/aragon/blob/master/src/network-config.js#L18! |
Thanks @sohkai , added straight to the configs :) |
…rere/use-wallet into re-enable-walletconnect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @JamesLefrere!
I added a few changes:
- Examples: tweak the buttons layout + add titles.
- Bump
@web3-react/walletconnect-connect
to6.1.4
. - Move to HTTP endpoints only. WS doesn’t seem to work with either WalletConnect or WalletLink to get the block number or the balance. It might be related to the way we are querying them? For now, I think the safest is to prevent users to set WS endpoints.
Great, thanks for taking care of that @bpierre 🙌 All sounds good, look forward to the release 👍 |
Changes
web3-react
jsonrpc
andid
property for all requests; ensuresendCompat
sends a request with these propertiesHope this is useful! I noticed the
sendCompat
issue with WalletLink, where the requests were failing; hopefully this is ok for the other providers?Cheers
James