Re-enable WalletConnect and add TypeScript definitions #37
Conversation
|
|
There was a problem hiding this comment.
Looking pretty good—could we also update the examples to include the WalletConnect connector?
I'll leave it to @andy-hook or @bpierre to check the type definition—🙇♂️ for adding it!
|
@sohkai Do you have an RPC endpoint to use for the examples? |
|
@JamesLefrere Not sure I understand; I was thinking of adding WalletConnect to this list (and a similar on in the other examples), and that shouldn't require an RPC endpoint? |
* Re-enable the WalletConnect connector * Upgrade connectors from `web3-react` * Bug fix: Some providers require a `jsonrpc` and `id` property for all requests; ensure `sendCompat` sends a request with these properties
JamesLefrere
force-pushed
the
re-enable-walletconnect
branch
from
5c67a98
to
f769810
Compare
|
@sohkai Yes, I have added them (with empty strings for the RPC urls) to the examples - it's just that it won't be able to connect without a real endpoint, but I guess that's ok for these examples. Also, semis removed 👍 |
|
@JamesLefrere Ah, I didn't realize that they needed RPC endpoints to work! You can use the endpoints defined here: https://github.com/aragon/aragon/blob/master/src/network-config.js#L18! |
|
Thanks @sohkai , added straight to the configs :) |
…rere/use-wallet into re-enable-walletconnect
There was a problem hiding this comment.
Thank you so much @JamesLefrere!
I added a few changes:
- Examples: tweak the buttons layout + add titles.
- Bump
@web3-react/walletconnect-connectto6.1.4. - Move to HTTP endpoints only. WS doesn’t seem to work with either WalletConnect or WalletLink to get the block number or the balance. It might be related to the way we are querying them? For now, I think the safest is to prevent users to set WS endpoints.
|
Great, thanks for taking care of that @bpierre 🙌 All sounds good, look forward to the release 👍 |
Changes
web3-reactjsonrpcandidproperty for all requests; ensuresendCompatsends a request with these propertiesHope this is useful! I noticed the
sendCompatissue with WalletLink, where the requests were failing; hopefully this is ok for the other providers?Cheers
James