Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vte_terminal_get_scroll_on_output #49

Closed
wants to merge 1 commit into from

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jul 27, 2022

Hi,

I've tried to use mlterm as a libvte engine as advertised in https://github.com/arakiken/mlterm/blob/master/gtk/README.

It works using gnome-terminal but fails on e.g. xfce4-terminal:

$ LD_PRELOAD=$MLTERM_PREFIX/lib/libvte-2.91.so gnome-terminal
$ LD_PRELOAD=$MLTERM_PREFIX/lib/libvte-2.91.so xfce4-terminal
xfce4-terminal: symbol lookup error: xfce4-terminal: undefined symbol: vte_terminal_get_scroll_on_output

Here is a patch defining vte_terminal_get_scroll_on_output (implementation to be discussed maybe: I don't know much of the mlterm internals...).

@arakiken arakiken closed this in 30daf46 Aug 16, 2022
@arakiken
Copy link
Owner

Thanks you! Sorry for my late reply.
I merged your patch with a little modification.

@t-bltg
Copy link
Contributor Author

t-bltg commented Aug 16, 2022

Awesome, and many thanks for the hard work in mlterm !

@t-bltg t-bltg deleted the get_scroll branch August 16, 2022 16:30
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 4, 2023
pkgsrc changes:
* make mlconfig.po installed properly (#66)
* remove local patches integrated into upstream

Upstream changes (noted in doc/en/ReleaseNote):

ver 3.9.3
* mlterm-wl supports xdg-decoration.
* Add --disable-compact-truecolor option to ./configure script.
* Add vte 0.68 API symbols to libvte compatible library.
* Add libvterm 0.2 API symbols to libvterm compatible library.
* Add --sdpr / simple_scrollbar_dpr option.
  (arakiken/mlterm#64)
* Set "COLORTERM=truecolor" environmental variable.
  (arakiken/mlterm#36)
* Update unicode property table (generated from UnicodeData.txt and
  EastAsianWidth.txt) to version 15.0.0.
* Support mosh-1.4.0.
* Merge patches:
  arakiken/mlterm#45.
  arakiken/mlterm#46.
  arakiken/mlterm#48.
  arakiken/mlterm#49.
  arakiken/mlterm#55. (Add --role / wm_role option)
  arakiken/mlterm#57.
  arakiken/mlterm#61.
  arakiken/mlterm#62.
  arakiken/mlterm#63.
* Bug fixes:
  Fix arakiken/mlterm#34.
  Fix arakiken/mlterm#35.
  Fix arakiken/mlterm#39.
  Fix arakiken/mlterm#44.
  Fix arakiken/mlterm#50.
  Fix arakiken/mlterm#51.
  Fix arakiken/mlterm#53.
  Fix https://twitter.com/isaki68k/status/1555895011991883783.
  Fix segfault in starting mlterm with --dyncomb and --otl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants