miscellaneous small cleanups #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
arakiken
requested changes
Mar 4, 2023
There was a problem hiding this comment.
Thanks.
These Makefiles are necessary to build mlclient and mlcc without executing ./configure.
I sometimes want to build just these tools on old machines where it takes many hours to execute ./configure script, so I place these Makefiles on purpose.
Don’t delete them.
configure.in unconditionally prints XIM as input method but it is only available with xlib UI. Skip it for other UIs. Also regenerate configure. Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Use pkgconfig to detect include path required for building wayland backend. Do not hardcode wayland libraries, use pkgconfig to detect them. Signed-off-by: Michal Suchanek <msuchanek@suse.de>
|
That also means that every time you do run configure these makefiles are modified, and you have to go out of your way to not commit these makefile changes together with your actual code changes. Maybe it would be better to move these to a different name like Makefile.static so that they can be used for this special purpose and not conflict with the generated ones? |
mlcc and mlclient have a static makefile shipped under the same filename as the generated makefile. Running configure overwrites these static makefiles with generated ones. That causes git to detect a file change in these makefiles, prevent most operations, and suggesting to include these changes in new commits. Move the makefiles away to prevent issues. Signed-off-by: Michal Suchanek <msuchanek@suse.de>
|
Thank you. I merged. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 4, 2023
pkgsrc changes: * make mlconfig.po installed properly (#66) * remove local patches integrated into upstream Upstream changes (noted in doc/en/ReleaseNote): ver 3.9.3 * mlterm-wl supports xdg-decoration. * Add --disable-compact-truecolor option to ./configure script. * Add vte 0.68 API symbols to libvte compatible library. * Add libvterm 0.2 API symbols to libvterm compatible library. * Add --sdpr / simple_scrollbar_dpr option. (arakiken/mlterm#64) * Set "COLORTERM=truecolor" environmental variable. (arakiken/mlterm#36) * Update unicode property table (generated from UnicodeData.txt and EastAsianWidth.txt) to version 15.0.0. * Support mosh-1.4.0. * Merge patches: arakiken/mlterm#45. arakiken/mlterm#46. arakiken/mlterm#48. arakiken/mlterm#49. arakiken/mlterm#55. (Add --role / wm_role option) arakiken/mlterm#57. arakiken/mlterm#61. arakiken/mlterm#62. arakiken/mlterm#63. * Bug fixes: Fix arakiken/mlterm#34. Fix arakiken/mlterm#35. Fix arakiken/mlterm#39. Fix arakiken/mlterm#44. Fix arakiken/mlterm#50. Fix arakiken/mlterm#51. Fix arakiken/mlterm#53. Fix https://twitter.com/isaki68k/status/1555895011991883783. Fix segfault in starting mlterm with --dyncomb and --otl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.