Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues about static mode redirectToLang=true #80

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

aralroca
Copy link
Owner

@aralroca aralroca commented Mar 13, 2020

#77

@justincy This PR fixes these issues:

(If en is the defaultLanguage)

  • / -> now it redirects correctly to /en
  • /en -> is not entering to bucle adding /en,en,en,en
  • /nested/example -> is redirecting correctly now to /en/nested/example. Before was redirecting to /en/nested,example

@justincy
Copy link
Contributor

🎉 That's the exact same solution I had just come up with.

@aralroca aralroca merged commit b6014df into master Mar 13, 2020
@aralroca aralroca deleted the fix-static-redirect-to-lang branch March 13, 2020 20:28
@aralroca
Copy link
Owner Author

@all-contributors add @justincy for code

@allcontributors
Copy link
Contributor

@aralroca

I've put up a pull request to add @justincy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants