More robust fetching of participants #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All these commits turn the stack trace from #419 to a more appropriate |
|
Perhaps there is a more clever way to achieve this (feel free to chime in). Considering the complexity of the ADNI converter code base I believe that's the least invasive and safest way to solve #419. |
The previous implementation fetched all directories within the BIDS path regardless of whether their name matched the sub-* pattern. Directories like `conversion_info` were wrongly listed as participant IDs later on.
Avoid potentiel KeyError due to missing session_id. This is more of a stop gap fix. A proper solution would require a deeper rewrite of the processing flow.
The converter used to interpret the absence of participants as a proxy for converting all the clinical data implicitly. This is a problem in case the conversion of the imaging data failed because no suitable data were found. Instead, let's make this behavior explicit using the option to request only the clinical data be processed.
ghisvail
force-pushed
the
fix-issue-419
branch
from
7692e2b
to
c755c21
Compare
omar-rifai
reviewed
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check each commit for contextual information about what is solved individually.
Closes #419