fix bug :http api for nodes #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add http server api for tenant * fix import format * fix go format Co-authored-by: Zhang Aphelios <aphelios.zhang@shopee.com>
jjeffcaii
reviewed
Sep 3, 2022
| nodesArray, err := service.ListNodes(c, cluster, group) | ||
| if err != nil { | ||
| _ = c.Error(err) | ||
| break |
jjeffcaii
reviewed
Sep 3, 2022
| result, err := service.GetNode(c, cluster, group, node) | ||
| if err != nil { | ||
| _ = c.Error(err) | ||
| continue |
There was a problem hiding this comment.
Should be return, and remove else.
jjeffcaii
reviewed
Sep 3, 2022
| groups, err := service.ListGroups(c, cluster) | ||
| if err != nil { | ||
| _ = c.Error(err) | ||
| continue |
jjeffcaii
reviewed
Sep 3, 2022
| data, err = service.GetNode(c, cluster, group, node) | ||
| if err != nil { | ||
| _ = c.Error(err) | ||
| continue |
There was a problem hiding this comment.
should be return.
I think should be continue ? 对于一组group Array 如果 在这之前group Array 中的一个元素返回了错误，没有调用通过service.GetNode(c, cluster, group, node) 返回一个node，但是其余的group Array中的元素有可能返回需要的node ，还是说对于这种情况，我们需要重新请求而不是返回出错信息和node
jjeffcaii
force-pushed
the
feat/admin-api
branch
from
1113978
to
bce3f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #344
Special notes for your reviewer:
Does this PR introduce a user-facing change?: