Skip to content

Commit

Permalink
by CoDEmanX: fix windows build for the non-express Visual Studios
Browse files Browse the repository at this point in the history
  • Loading branch information
dothebart committed Aug 19, 2015
1 parent 353bdb2 commit 796d2d2
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions 3rdParty/V8-4.3.61/build/gyp/pylib/gyp/generator/msvs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1693,7 +1693,9 @@ def _DictsToFolders(base_path, bucket, flat):
children += folder_children
else:
folder_children = MSVSNew.MSVSFolder(os.path.join(base_path, folder),
name='(' + folder + ')',
# parentheses not supported by msbuild target parameter /t
# name='(' + folder + ')',
name=folder,
entries=folder_children)
children.append(folder_children)
else:
Expand Down Expand Up @@ -1967,7 +1969,9 @@ def GenerateOutput(target_list, target_dicts, data, params):
sln_projects += gyp.common.DeepDependencyTargets(target_dicts, sln_projects)
# Create folder hierarchy.
root_entries = _GatherSolutionFolders(
sln_projects, project_objects, flat=msvs_version.FlatSolution())
# ArangoDB V8 build script expects flat solution
# sln_projects, project_objects, flat=msvs_version.FlatSolution())
sln_projects, project_objects, flat=True)
# Create solution.
sln = MSVSNew.MSVSSolution(sln_path,
entries=root_entries,
Expand Down

0 comments on commit 796d2d2

Please sign in to comment.