Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ccache optional #10310

Merged
merged 1 commit into from
Oct 24, 2019
Merged

make ccache optional #10310

merged 1 commit into from
Oct 24, 2019

Conversation

fceller
Copy link
Contributor

@fceller fceller commented Oct 24, 2019

Pull Request Guidelines

Pull requests are an essential collaborative tool for modern software development.

The below list is intended to help you figure out whether your code is ready to be reviewed
and merged into ArangoDB. The overarching goal is to:

  • Reduce the amount of recurring defects
  • Reduce the impact to the other developer’s time and energy spent on defects in your code
  • Increase the overall autonomy and productivity of individual developers

Acceptance Checklist

The below list is not exhaustive, think thoroughly whether the provided information is sufficient.
Remove options that do not apply

Scope & Purpose

(Can you describe what functional change your PR is trying to effect?)

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • [x ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • [ x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Related Information

(Please reference tickets / specification etc )

  • There is a GitHub Issue reported by a Community User:
  • There is an internal planning ticket:
  • There is a JIRA Ticket number (In case a customer was affected / involved):
  • There is a design document:

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

Notes

This needs to be ported to upstream!

@fceller fceller requested a review from gnusi October 24, 2019 07:38
@fceller fceller merged commit 1a83aaa into devel Oct 24, 2019
@fceller fceller deleted the feature/use-ccache branch October 24, 2019 08:58
fceller added a commit that referenced this pull request Oct 24, 2019
fceller added a commit that referenced this pull request Oct 24, 2019
ObiWahn added a commit that referenced this pull request Oct 24, 2019
…ture/cpp17-clean-up

* 'devel' of https://github.com/arangodb/arangodb:
  make ccache optional (#10310)
  abort write transactions (#10248)
  url-encode and -decode in place (#10301)
  updated CHANGELOG
  upgrade boost to version 1.71.0 (#10299)
  Feature/explain spliced subqueries (#10298)
  Revert "Feature/react webpack testing (#8712)"
  Feature/react webpack testing (#8712)
  Bug fix/make result ctor noexcept (#10293)
  micro optimizations for case conversion (#10291)
  fix error message (#10281)
  Add Linux to -Werr (#10294)
  make sure error files get built when arangod is built (#10284)
ObiWahn added a commit that referenced this pull request Oct 25, 2019
…ture/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (26 commits)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
  abort write transactions (#10248)
  url-encode and -decode in place (#10301)
  updated CHANGELOG
  upgrade boost to version 1.71.0 (#10299)
  Feature/explain spliced subqueries (#10298)
  Revert "Feature/react webpack testing (#8712)"
  Feature/react webpack testing (#8712)
  Bug fix/make result ctor noexcept (#10293)
  micro optimizations for case conversion (#10291)
  fix error message (#10281)
  Add Linux to -Werr (#10294)
  make sure error files get built when arangod is built (#10284)
  reactivate warnings as errors (#10286)
  remove extra JSON parser (#10282)
  don't show "NaN" in web interface for cluster RAM usage (#10283)
  Bug fix/some future massaging (#10285)
  ...
ObiWahn added a commit that referenced this pull request Oct 28, 2019
…ture/smart-join-views-2

* 'devel' of https://github.com/arangodb/arangodb:
  rawPayload shouldn't return the full reply buffer (#10319)
  micro optimizations (#10316)
  test attempt to increase max collection name length from 64 chars to 256 (#9890)
  Feature/force backup (#10265)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants