Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/micro optimize auth #10316

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Bug fix/micro optimize auth #10316

merged 2 commits into from
Oct 25, 2019

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Some micro optimizations

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/6874/

@jsteemann jsteemann added this to the devel milestone Oct 24, 2019
@jsteemann
Copy link
Contributor Author

Copy link
Contributor

@ObiWahn ObiWahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann
Copy link
Contributor Author

@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann merged commit 669bd40 into devel Oct 25, 2019
@jsteemann jsteemann deleted the bug-fix/micro-optimize-auth branch October 25, 2019 16:40
ObiWahn added a commit that referenced this pull request Oct 25, 2019
* origin/devel:
  micro optimizations (#10316)
  test attempt to increase max collection name length from 64 chars to 256 (#9890)
  Feature/force backup (#10265)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
ObiWahn added a commit that referenced this pull request Oct 28, 2019
…ture/smart-join-views-2

* 'devel' of https://github.com/arangodb/arangodb:
  rawPayload shouldn't return the full reply buffer (#10319)
  micro optimizations (#10316)
  test attempt to increase max collection name length from 64 chars to 256 (#9890)
  Feature/force backup (#10265)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants